#998 ✓resolved
Anthony Williams

[PATCH] Fixes for find_by_sql on DM 0.10

Reported by Anthony Williams | August 1st, 2009 @ 04:57 PM | in 0.10.0

Please forgive the rather vague ticket title...

Attached is a patch which fixes find_by_sql from the dm-ar-finders plugin, so that it works on DM 0.10. I wish I could point to specific fixes but, without meaning to be at all rude, the previous version didn't seem to work at all.

  • Fixes so that passing in an array with a query and bind values works. Previously, find_by_sql would try to extract the values from *args, rather than just the array (which is the first argument).
  • Fixes so that supplying an options hash only sets the options which are explicitly given.
  • Adds specs which were previously missing.

If it's easier, the patch is also available on my Github repo: http://github.com/antw/dm-more/commit/7971afa092d9e701ac06d4900813f...

Many thanks for your time,
Anthony.

Comments and changes to this ticket

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Attachments

Pages