Datamapper DataMapper

Comments and changes to this ticket

• You flagged this item as spam.
  

  Dane Jensen December 14th, 2007 @ 03:39 PM

  The 'DataMapper::Adapters::PostgresqlAdapter::Mappings::Table should search only the specified schema if qualified' spec is likely failing because the SQL generated is:

  SELECT TABLE_NAME FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_NAME = 'my_schema.cages' AND TABLE_CATALOG = 'data_mapper_1'
  
  But table_name is only the name of the table, the schema name is in table_schema. This would work however:
  
  

  SELECT TABLE_NAME FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_NAME = 'cages' AND TABLE_SCHEMA = 'my_schema' AND TABLE_CATALOG = 'data_mapper_1'

• 

  Bjørn Arild Mæland December 18th, 2007 @ 06:27 AM

  • State changed from “new” to “open”

  Running the spec suite on Debian 4.0 with PostgreSQL 8.1 causes 7 errors.

• You flagged this item as spam.
  

  Dane Jensen December 23rd, 2007 @ 01:33 PM

  I've attached a patch that fixes the errors in postgres_spec.rb that were preventing it from running.

  • fix_postgres_spec.rb.patch 1.6 KB
• 

  Dane Jensen December 23rd, 2007 @ 01:42 PM

  • no changes were found...

  • postgres_schema_support.patch 1.9 KB

• You flagged this item as spam.
  

  Dane Jensen December 27th, 2007 @ 10:18 AM

  And with fix_postgres_spec.rb.patch applied, the spec fails with:

  'DataMapper::Adapters::PostgresqlAdapter::Mappings::Table should search only the specified schema if qualified' FAILED
  expected: true,
       got: false (using ==)
  ./spec/postgres_spec.rb:57:
  
  Which is fixed by postgres_schema_support.patch, but probably not in the most elegant way. I'm still getting acquainted with the source :).
  

• You flagged this item as spam.
  

  Sam Smoot December 27th, 2007 @ 10:19 AM

  • Milestone cleared.

  Putting this on the plate for 0.3.0. Want to make sure that's the "production ready" release.

• You flagged this item as spam.
  

  Sam Smoot January 13th, 2008 @ 11:49 PM

  • State changed from “open” to “resolved”

  These should be resolved I believe. If we have other breakages, let's open new tickets.