#830 ✓resolved
chase

extlib bug

Reported by chase | April 9th, 2009 @ 02:30 PM

In extlib/module.rb, in nested_const_lookup, the line constants << const.const_get(part) should be changed to constants.unshift(const.const_get(part))

Comments and changes to this ticket

  • Dan Kubb (dkubb)

    Dan Kubb (dkubb) May 28th, 2009 @ 07:26 PM

    • State changed from “unconfirmed” to “accepted”
    • Assigned user set to “Dan Kubb (dkubb)”
  • Dan Kubb (dkubb)

    Dan Kubb (dkubb) June 7th, 2009 @ 01:38 AM

    • State changed from “accepted” to “hold”

    @chase: are you sure about that? Making that change breaks a couple of specs.

    I reviewed the logic and it looks like it does the right thing to me. Is there some sort of problem that necessitates this change?

  • Dan Kubb (dkubb)

    Dan Kubb (dkubb) June 16th, 2009 @ 03:18 AM

    • State changed from “hold” to “not-applicable”

    Marking this ticket as not applicable due to no response from original submitter, no failing specs, and no issues discovered after review.

  • chase

    chase June 17th, 2009 @ 12:41 PM

    Oh sorry about no response! I forgot my password and the password reset emails went into my junk folder (I should have looked there!) Anyway, I think that line # 23 or so, in the nested_const_lookup method should change from

    constants << const.const_get(part)

    to

    constants.unshift(const.const_get(part))

    My application won't work without this change, because the models can't find each other. So I assume (rightly or wrongly) that others would experience the same problem.

  • Dan Kubb (dkubb)

    Dan Kubb (dkubb) June 17th, 2009 @ 02:10 PM

    • State changed from “not-applicable” to “unconfirmed”

    @chase: can you make the change locally and run the specs to see the failures? Some of those shouldn't be there, and its important that they continue to pass.

  • chase

    chase June 17th, 2009 @ 02:33 PM

    Ok. I have already made the change locally (otherwise the application won't work). I will run the specs and see how it goes.

  • chase

    chase June 17th, 2009 @ 03:08 PM

    Oh I think I see what happened. On 2009-05-05 you "Fixed constant lookup for nested constructs" and changed

    const = constants.first || Object

    to

    const = constants.last || Object

    That was another way to fix the problem I had found.

    So everything seems to be OK now.

  • Dan Kubb (dkubb)

    Dan Kubb (dkubb) June 17th, 2009 @ 03:58 PM

    • State changed from “unconfirmed” to “resolved”

    Ahh yeah, great. Ok. I will close this now. I assume you've tried the latest extlib and it works for you?

  • chase

    chase June 17th, 2009 @ 04:03 PM

    Yes, thanks Dan. I just had not realized you had fixed the bug after my report on 4/9. My fix undid your fix, and vice versa, and that caused some confusion.

    I ran my specs with the new version of extlib and they passed.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

People watching this ticket

Pages