#76 ✓resolved
Paul Sadauskas (Rando)

Move important methods out of ARImpersonations Module and into Base

Reported by Paul Sadauskas (Rando) | November 26th, 2007 @ 09:53 PM

As discussed in this thread http://groups.google.com/group/d... I have refactored methods critical to using DM into ::Base, added a few quick comments, and moved the specs to the correct file.

Comments and changes to this ticket

  • Sam Smoot

    Sam Smoot December 28th, 2007 @ 10:47 PM

    • Milestone cleared.
    • State changed from “new” to “open”

    Ah... sorry for letting this sit so long.

    Some of these methods have changed since the patch (#[] is an obvious one). So we'd need to regenerate.

    Also, the biggest change is that the methods would probably move into the DataMapper::Persistence module now instead of DataMapper::Base.

    Aside from those concerns, looks good to me. Might as well get it done sooner rather than later. I'm marking this one for 0.3.0.

    Paul, if you can manage to commit an updated version I'd appreciate it. Otherwise I'll try to get around to it myself.

  • Bernerd Schaefer

    Bernerd Schaefer January 6th, 2008 @ 10:33 AM

    • Assigned user set to “Bernerd Schaefer”

    This is now done [r685]. I remember we discussed being on the fence about what to wrap the methods in, so I went ahead and put them in DataMapper::Persistence::ConvenienceMethods

  • Bernerd Schaefer

    Bernerd Schaefer January 6th, 2008 @ 12:56 PM

    • State changed from “open” to “resolved”

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

People watching this ticket