[PATCH] Nokogiri support for dm-serializer
Reported by Greg Campbell | January 2nd, 2009 @ 11:12 AM
I've patched in support for Nokogiri for XML generation in dm-serializer. I also extracted the XML manipulation in the to_xml_document methods into a common module interface consisting of three methods (new_document, root_node, add_node) that wrap underlying library methods, so it should be pretty straightforward to add new XML libraries if that becomes helpful.
The relevant commit is http://github.com/gcampbell/dm-m...
Comments and changes to this ticket
-
Xavier Shay January 2nd, 2009 @ 11:15 AM
- Tag set to “dm-serializer, nokogiri, patch”
- State changed from “unconfirmed” to “accepted”
fantastic! Thanks.
-
Greg Campbell January 2nd, 2009 @ 11:52 AM
As a note, another approach I considered was writing some generic proxy objects for XML Documents, Nodes, etc that would wrap underlying objects from the various XML libraries with a generic interface. That seemed a bit overengineered for something that's only used internally, but it might be worth considering as an alternative if we need to use more XML functionality in the course of serialization.
-
Xavier Shay January 2nd, 2009 @ 03:16 PM
- State changed from “accepted” to “resolved”
Applied, agree re proxy idea, what we have now serves our purpose nicely.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Greg Campbell
Xavier Shay