Datamapper DataMapper

Comments and changes to this ticket

• You flagged this item as spam.
  

  zeijeigo December 29th, 2008 @ 09:36 PM

  I've only started with Datamapper today, but I think this simple patch to dm-core/associations/relationship.rb (around line 95) should fix the problem.

    grouped_collection = {}
  + query_values.each do |key|
  +   parent_obj = parent_identity_map[key]
  +   grouped_collection[parent_obj] = []
  + end
    collection.each do |resource|
    child_value = child_key.get(resource)
      parent_obj = parent_identity_map[child_value]
  -   grouped_collection[parent_obj] ||= []
      grouped_collection[parent_obj] << resource
    end
  
  

• You flagged this item as spam.
  

  zeijeigo December 29th, 2008 @ 10:33 PM

  Or perhaps query_values.each should be bind_values.each, since this is the one used in actualy query. I'm not able to make out the difference between the two.

• You flagged this item as spam.
  

  zeijeigo December 29th, 2008 @ 10:57 PM

  grouped_collection = {}

  + bind_values.each do |key|
  +   parent_obj = parent_identity_map[key]
  +   grouped_collection[parent_obj] = []
  + end
    collection.each do |resource|
      child_value = child_key.get(resource)
      parent_obj = parent_identity_map[child_value]
  -   grouped_collection[parent_obj] ||= []
      grouped_collection[parent_obj] << resource
    end
  
  

• 

  Dan Kubb (dkubb) January 8th, 2009 @ 05:18 AM

  • State changed from “unconfirmed” to “accepted”
  • Assigned user set to “Dan Kubb (dkubb)”
• 

  Dan Kubb (dkubb) May 28th, 2009 @ 01:53 AM

  • State changed from “accepted” to “resolved”

  This issue should be resolved in the dm-core/next branch.

  I explicitly initialize associations in all siblings, even when there the association is empty. This prevents extra queries from being executed to lazy-load the non-existent records.