do/do_mysql missing timezone_to_offset
Reported by Shane Hanna | December 1st, 2008 @ 11:49 PM
This patch broke do_mysql I think.
http://github.com/sam/do/commit/...
It calls the method timezone_to_offset which is never defined in do/do_mysql/ext/do_mysql_ext.c
Sorry I don't have a test or patch for this one yet.
Cheers, Shane.
Comments and changes to this ticket
-
Shane Hanna December 2nd, 2008 @ 12:23 AM
I assume the author just forgot to rake compile:mri before running the specs on his changes. They fail for me with "dyld: lazy symbol binding failed: Symbol not found: _timezone_to_offset" on OSX.
Anyway do_mysql specs run clean (with 5 pending) using the following patch. I hope thats ok.
http://github.com/shanna/do/comm...
Cheers, Shane.
-
Dan Kubb (dkubb) December 2nd, 2008 @ 12:28 AM
- Assigned user set to “Dirkjan Bussink”
- State changed from “new” to “resolved”
Thanks for the patch. I've pushed it in this commit:
http://github.com/sam/do/commit/...
Also notifying Dirkjan. It's an easy mistake to make, but I've found it's always useful to run "rake clobber compile spec" before pushing stuff to DO. Sometimes artifacts from earlier compilations hang around and affect testing results.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Dirkjan Bussink
Shane Hanna