Datamapper DataMapper

Comments and changes to this ticket

• You flagged this item as spam.
  

  Arthur Zapparoli November 26th, 2008 @ 12:50 AM

  • Assigned user cleared.

  I'm attaching a patch file for that. It's the best method instead of github commits?

  • 0001-Added-Model-first_or_initialize.patch 2.1 KB
• 

  Dan Kubb (dkubb) November 26th, 2008 @ 11:43 PM

  This patch probably won't be applied to sam/dm-core, which is basically just in maintenance mode while the docs and specs for dkubb/dm-core are being worked on.

  However, I would be open to having a first_or_new method in both Model and Collection, since both already (or will) have a first_or_create method.

  Also the implementation of the method can be made even simpler than what you have:

  
  def first_or_create(query, attributes = {})
    first(query) || new(query.merge(attributes))
  end
  

• 

  Dan Kubb (dkubb) November 27th, 2008 @ 12:05 AM

  • State changed from “new” to “resolved”
  • Assigned user set to “Dan Kubb (dkubb)”

  This has now been added as per the following commit:

  http://github.com/dkubb/dm-core/...

  Please note that there are no specs for Model#first_or_create or Model#first_or_new because some of the "finders" in Collection will have their specs extracted into a shared spec for use in testing Model, Collection, OneToMany::Proxy and ManyToMany::Proxy.

  Also note the finders will likely be extracted into their own module for inclusion into Model and Collection to ensure the behavior is consistent between the two.