dm-is-versioned fails spec save with clean existing resource
Reported by glenndavy | October 20th, 2008 @ 09:06 PM
fails test: DataMapper::Is::Versioned#save (with a clean existing resource) - should not create a versioned copy
have attached patch that simple checks self.dirty?
hope this isn't too naive a fix.
am new to dm, but am keen to get involved, please let me know if i've gone about anything wrong way here.
thanks Glenn
Comments and changes to this ticket
-
Dan Kubb (dkubb) January 8th, 2009 @ 02:19 PM
- State changed from “new” to “unconfirmed”
- Assigned user cleared.
-
Dan Kubb (dkubb) January 8th, 2009 @ 04:14 PM
- Assigned user set to “Jamie Macey”
-
Jamie Macey February 21st, 2009 @ 10:52 PM
Passing spec for this has been added since ticket was created.
dkubb: Should this be marked resolved or not-applicable?
-
Dan Kubb (dkubb) February 22nd, 2009 @ 12:32 AM
- Tag changed from “dm-is-versioned” to “bug, dm-is-versioned”
- State changed from “unconfirmed” to “resolved”
@jamie: The not-applicable status is basically like saying "this ticket was not valid and is either due to a misunderstanding of the usage, or a bug in the user's code". It's just a nicer way of saying "invalid, won't fix" ;)
This clearly isn't the case with glenndavy's ticket, which is totally valid, and fixed in edge, so I would/will mark this as resolved.
I usually also like to make sure real bugs are tagged with "bug". It just gives us a way of seeing how many true bugs are reported, and how we're handling them.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Dan Kubb (dkubb)
Jamie Macey