#6 invalid
Sam Smoot

Loader reorganization

Reported by Sam Smoot | October 4th, 2007 @ 03:07 PM

The Loaders are grouped in an Array right now, and serviced one after the other. It makes more sense for them to mirror the object-graph they're loading. So a Loader: has_many => Loaders basically, and the database row would be passed down recursively.

Comments and changes to this ticket

  • Sam Smoot
  • Sam Smoot
  • Sam Smoot

    Sam Smoot October 25th, 2007 @ 11:29 PM

    • Milestone cleared.

    Need to get this out of the way... prioritizing for the next release.

  • Sam Smoot

    Sam Smoot November 2nd, 2007 @ 12:40 PM

    • Milestone cleared.

    Eh, half way done. Not going to hold up the release for the remainder.

  • Nick Plante
  • Sam Smoot

    Sam Smoot November 12th, 2007 @ 09:20 AM

    • Milestone cleared.

    I have a plan.

    Create a DM::Base::load method. More speed. More goodness. Simplify the call-stack. Let's line this one up for a 0.4.0 release though. I don't want to hold up all the feature goodness in 0.3.0 for simple non-breaking-API changes for performance.

  • Sam Smoot

    Sam Smoot November 13th, 2007 @ 06:59 AM

    Ok... I'm itching to take this on. :)

    First, I need to bust out the #load method, and figure out if it'll meet my needs... Then, bit by bit, I can start moving towards it. Like replacing DM::Base#[] to just a find(id) alias.

    Which also involves moving the ActiveRecordImpersonation out into a plugin module, and moving most (but not all) of the delegate methods currently defined there into DM::Base.

  • Sam Smoot

    Sam Smoot December 28th, 2007 @ 10:10 PM

    • State changed from “open” to “invalid”

    Ok... this ticket is obviously going nowhere. In fact, some of the changes I made (condensing Conditions into LoadCommand) are being rolled back (justifiably). Until I have a better idea of what I'm trying to do I'm going to close this one out.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

People watching this ticket

Referenced by

Pages