patch for numeric validations
Reported by Joe Grossberg | August 5th, 2008 @ 02:35 PM | in 0.10.0
Includes specs for eq, neq, lt, lte, gt, gte -- tested on numeric strings, integers and floats.
Comments and changes to this ticket
-
Dan Kubb (dkubb) August 5th, 2008 @ 04:52 PM
- State changed from “new” to “open”
This looks good. The only small nitpick I can see is that instead of "neq" you should probably use "ne" since that matches the convention of DM's finder syntax.
-
-
Joe Grossberg August 5th, 2008 @ 08:48 PM
So, should I do the github thing now? Sorry I'm not more familiar with how to contribute to open source projects; I want to follow the proper etiquette, to make the mergers' lives easier.
-
Joe Grossberg August 6th, 2008 @ 09:44 AM
- no changes were found...
-
Joe Grossberg August 6th, 2008 @ 09:49 AM
OK, created a github patch, per the instructions on Michael Ivey's blog.
-
-
Joe Grossberg August 8th, 2008 @ 10:29 AM
Tymon:
IMHO, it's still a worthwhile patch because:
- this one parallels the DM finder syntax
- its location is unintuitive (who'd think to use something called WithinValidator to ensure a number is greater than zero? Maybe I'm particularly foolish, but I hadn't)
As far as the objection to it being redundant, everything is redundant when we can do a MethodValidator. :)
-
Dan Kubb (dkubb) January 8th, 2009 @ 02:21 PM
- State changed from “open” to “unconfirmed”
- Assigned user cleared.
-
Dan Kubb (dkubb) January 8th, 2009 @ 02:22 PM
- Assigned user set to “Michael Klishin (antares)”
-
Michael Klishin (antares) January 9th, 2009 @ 06:02 PM
- State changed from “unconfirmed” to “hold”
I would apply this if you rebase it against dm-more/master. It does not apply currently. Thank you.
-
Michael Klishin (antares) March 25th, 2009 @ 04:57 PM
- Milestone set to “0.10.0”
- State changed from “hold” to “accepted”
next on my plate
-
Michael Klishin (antares) March 28th, 2009 @ 08:48 AM
- State changed from “accepted” to “resolved”
Applied it manually with change in logic: options now can be combined. In original patch they were exclusive.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Dan Kubb (dkubb)
Michael Klishin (antares)
Rick