Write unit specs for dm-migrations
Reported by Paul Sadauskas (Rando) | July 3rd, 2008 @ 09:31 PM
There are currently no unit specs in migrations, only integration. Here's a list of the things I'm going to do in the next few days:
- Unit test the hell outta everything
- Remove the redundant integration specs, and just spec that the migrations work
- Copy all the methods out of dm-core adapters that are marked "TODO: Move to dm-migrations"
- See what it will take to move automigrations into dm-migrations. Work with Dan Kubb and whoever else wants to. Any good ideas, please add a comment to this ticket.
- Do that.
Comments and changes to this ticket
-
-
Jonathan Stott (namelessjon) November 30th, 2008 @ 08:18 AM
- Milestone cleared.
- State changed from “new” to “open”
Rando, what is the status of this?
-
Paul Sadauskas (Rando) December 12th, 2008 @ 04:57 PM
- State changed from “open” to “not-applicable”
-
Dan Kubb (dkubb) December 12th, 2008 @ 06:51 PM
I think the reason Rando marked this as not-applicable is because what we used to think of as unit specs aren't actually that helpful. They're brittle, require you to write a set of mock objects, keep those mocks in sync with the real objects and generally duplicate the same tests you should be running anyway in the integration specs.
With dkubb/dm-core (and future spec updated to dm-more and DO) we'll purge all unit specs from the system. We shouldn't accept anymore unit specs into the current "sam" repos either.
-
Paul Sadauskas (Rando) December 12th, 2008 @ 09:22 PM
Actually, i marked it not applicable, because it failed your 'not a to-do list' criteria.
This was essentailly the todo item for merging auto-migrations and migrations
-
Dan Kubb (dkubb) December 13th, 2008 @ 02:20 AM
Ahh yeah. I was going to mention that too. Either reason works ;)
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Paul Sadauskas (Rando)