Migrations for SqLite3 Broken in Adapter
Reported by DaveLangston | July 3rd, 2008 @ 08:21 PM
2 problems:
1) primary key is not getting created in sqlite3 adapter (affects all users of migrations using DM property syntax in migration). Due to 'typo' hash key in method property_schema_statement
2) dm-migrations uses method property_schema_statement but it is 'private' in sqlite3_adapter.rb
fixes in attached patch
Comments and changes to this ticket
-
Paul Sadauskas (Rando) July 3rd, 2008 @ 09:27 PM
- State changed from “new” to “open”
- Tag set to “bug, dm-core, migrations, patch”
- Assigned user changed from “Sam Smoot” to “Paul Sadauskas (Rando)”
Thanks for this, Dave. I'm currently in the process of writing better unit specs for the migrations, and then I'm going to move all those lines littered with "TODO: Move this". I'll apply your patch, and make sure the fixes get included when I move everything.
-
Paul Sadauskas (Rando) July 3rd, 2008 @ 10:44 PM
- State changed from “open” to “resolved”
Fixed in http://github.com/sam/dm-core/co...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Paul Sadauskas (Rando)