#419 ✓resolved
Steve Tooke (tooky)

to_xml does not create xml compatible with ActiveResource

Reported by Steve Tooke (tooky) | June 26th, 2008 @ 04:49 PM

The XML generated by dm-serializer does not produce the type attributes required by ARes. Is this the intended behaviour?

Would patches for this be accepted?

Comments and changes to this ticket

  • Steve Tooke (tooky)

    Steve Tooke (tooky) June 26th, 2008 @ 05:42 PM

    I've added some specs + fixes for this. It also starts to address the issue of collections in #165.

    You can pull branch dm-serializer-to-xml from git://github.com/tooky/dm-more.git to see.

    Any comments or suggestions more than welcome :)

  • Dan Kubb (dkubb)

    Dan Kubb (dkubb) June 26th, 2008 @ 07:03 PM

    • Assigned user changed from “Sam Smoot” to “Dan Kubb (dkubb)”

    Yes, for now the goal is to have to_xml output ARs compatible XML by default. In the future we'd like to see it become flexible enough to handle other cases, but ARs compat. is a good first step.

  • Dan Kubb (dkubb)

    Dan Kubb (dkubb) June 27th, 2008 @ 01:51 PM

    • State changed from “new” to “resolved”

    Steve, I've merged your branch with dm-more, so I'm marking this ticket as resolved.

    I sent you an email through github, but I'll repeat it here too. Should we also include the XML prolog in the output of both a Resource and a Collection object? eg:

    <?xml version="1.0" encoding="UTF-8"?>

  • Steve Tooke (tooky)

    Steve Tooke (tooky) June 28th, 2008 @ 03:27 AM

    Great thanks Dan.

    I'm not sure about the XML processing statement? I guess it should be there? It would be pretty easy to add.

    I guess its a few bytes that could be saved if left out though ;)

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

People watching this ticket