#397 ✓resolved
Dan Sully

DM should have a pluggable logger

Reported by Dan Sully | June 17th, 2008 @ 07:49 PM | in 0.10.0

DM::Logger should not default to a relative path file.

This causes massive permission issues.

Additionally, DM::Logger should be able to take an existing Logger (or compatible) object and not just a String/IO

Comments and changes to this ticket

  • Dan Kubb (dkubb)

    Dan Kubb (dkubb) June 17th, 2008 @ 08:40 PM

    • Milestone cleared.

    As a side note, wycats is currently integrating merb with extlib, and I've asked hassox to pass along a message to him to move merb's logger to extlib since dm's is basically an exact copy. I'd like to see dm's logger, do's logger, and the do_* loggers be replaced with the future logger in extlib.

    If the changes need to be incorporated into the logger, we should probably make sure they make it into the extlib logger too.

  • Jonathan Stott (namelessjon)

    Jonathan Stott (namelessjon) November 30th, 2008 @ 08:23 AM

    • Tag set to bug, dm-core
    • State changed from “new” to “open”
    • Assigned user cleared.

    This is still apparently not possible as of dm-core 0.9.7 and extlib 0.9.8

  • Michael Klishin (antares)

    Michael Klishin (antares) January 10th, 2009 @ 06:53 AM

    • State changed from “open” to “confirmed”
    • Assigned user set to “Michael Klishin (antares)”
    • Title changed from “DataMapper::Logger issues.” to “DM should have a pluggable logger”
  • Dan Kubb (dkubb)

    Dan Kubb (dkubb) January 11th, 2009 @ 02:19 AM

    As a side note, it looks like the Logger was extracted into Extlib, but DM wasn't updated to use it directly and uses an almost exact copy of Extlib::Logger, which seems a bit un-DRY. Refactoring DM's logger to use Extlib::Logger will likely be one of the goals prior to DM 1.0

  • Martin Gamsjaeger (snusnu)

    Martin Gamsjaeger (snusnu) July 9th, 2009 @ 07:00 PM

    Is it sensible to close this ticket now that dm uses extlib/logger?

  • Dan Kubb (dkubb)

    Dan Kubb (dkubb) July 9th, 2009 @ 07:17 PM

    • Assigned user changed from “Michael Klishin (antares)” to “Dan Kubb (dkubb)”
    • State changed from “confirmed” to “resolved”
  • Dan Kubb (dkubb)

    Dan Kubb (dkubb) July 9th, 2009 @ 07:17 PM

    • Milestone set to 0.10.0

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Tags

Pages