#305 ✓resolved
Philipp Pirozhkov

Properties doesn't become dirty

Reported by Philipp Pirozhkov | May 23rd, 2008 @ 06:03 AM

If we have a Resource, all its properties got dirty when they are directly chaged,i.e.

resource.property=new_value

But there are some other cases when property should be dirty:

resource.a={}

resource.dirty? #true

resource.save

resource.dirty? #false

resource.a[:q]='sdsdfsdf'

resource.dirty? #false !!!

This affects merb_datasessions a lot, where DataMapperSession's data property is a hash, and it doesn't get dirty on adding a value to it, and the session.save returns false (since .dirty? is false), and session data is not saved.

Comments and changes to this ticket

  • Bernerd Schaefer

    Bernerd Schaefer June 10th, 2008 @ 12:46 PM

    • State changed from “new” to “open”
    • Assigned user changed from “Sam Smoot” to “Bernerd Schaefer”

    I added a pending spec to dm-core for the dirty tracking part of this ticket.

    I've also attached a patch for data_mapper_session that makes use of some new things in dm-core. Once the tracking is done, the patch should be able to be applied.

  • Bernerd Schaefer

    Bernerd Schaefer June 12th, 2008 @ 05:04 PM

    • State changed from “open” to “resolved”

    This should now be fixed in edge. Let me know if it's still not working for you.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

People watching this ticket

Attachments

Pages