Datamapper DataMapper

Comments and changes to this ticket

• 

  Alex Coles May 22nd, 2008 @ 06:44 AM

  (I can't currently assign myself to this -- but I will try to investigate. Bug is in here to track)

• 

  Alex Coles May 22nd, 2008 @ 07:13 AM

  • Title changed from “Numeric Validator throwing a RegexpError” to “RegexpError when using auto-validated Float properties”

  Reduced this down to a problem with Floats and auto-validations.

  This works:

      class Fish
        include DataMapper::Resource
        property :id,     Integer, :serial => true
        property :scales, Integer
        property :average_weight, Float, :auto_validation => false
        validates_is_number :average_weight
      end
      
      fish = Fish.new
      fish.scales = 1
      fish.average_weight = 20.22
      fish.valid?.should == true # => true
  

  and this does not:

      class Fish
        include DataMapper::Resource
        property :id,     Integer, :serial => true
        property :scales, Integer
        property :average_weight, Float
      end
      
      fish = Fish.new
      fish.scales = 1
      fish.average_weight = 20.22
      fish.valid?.should == true 
      # RegexpError =>can't do {n,m} with n > m: /\A(?:\d{1,10}|\d{0,10}\.\d{1,0})\z/
  
  

• 

  Alex Coles May 22nd, 2008 @ 07:34 AM

  Should be fixed in commit c88cc4e

  (As an aside, all of the validations need better specs).

• 

  Dan Kubb (dkubb) May 25th, 2008 @ 07:40 PM

  • State changed from “new” to “resolved”

  Verified this ticket is fixed and beefed up the specs to handle extra conditions: http://github.com/sam/dm-more/co...