fixes to performance.rb script
Reported by Josh Goebel | May 24th, 2008 @ 07:10 AM
I had some problems getting started with performance.rb so I thought I would contribute my changes...
I don't know why we wouldn't use IF EXISTS since we seem to be using mysql as the default benchmarking platform and unless I create that table before running the benchmarks they blow up. Also I'm wondering if the "tmp/*" socket entries shouldn't be "/tmp/*" but I went ahead and added rooted paths and left the unrooted ones as well.
Comments and changes to this ticket
-
Dan Kubb (dkubb) May 20th, 2008 @ 07:01 PM
- State changed from “new” to “resolved”
I fixed this problem by changing the script to use auto_migrate! which performs the DROP IF EXISTS automatically.
Please re-open if this did not resolve the problem for you.
-
Josh Goebel May 24th, 2008 @ 07:10 AM
Why was the top portion of my patch not applied that would improved compatibility with more MySQL installs?
-
Dan Kubb (dkubb) May 24th, 2008 @ 11:10 AM
Josh, thanks for the heads up. I must've missed that part. I was working on a branch and updated the performance.rb script to use auto_migrate! and I missed the part of your patch that added the /tmp paths.
Your patch has been committed:
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
People watching this ticket
Dan Kubb (dkubb)
Attachments
Referenced by
-
308
Re-open please
http://wm.lighthouseapp.com/proj...
-
308
Re-open please
Commit #290 has been resolved.