#233 invalid
Sergei Yakovlev

Bad results when no :key/:serial properties

Reported by Sergei Yakovlev | May 3rd, 2008 @ 02:46 PM

If there are no properties with => true or => true declared in the model, incorrect results are returned. See attached example.

Comments and changes to this ticket

  • Sergei Yakovlev

    Sergei Yakovlev May 3rd, 2008 @ 02:48 PM

    :serial => true
    :key => true
  • Sam Smoot

    Sam Smoot May 8th, 2008 @ 05:28 PM

    Right. For now keys are a requirement. We can loosen that requirement with a little work (it just means we can't lazy-load, guess association keys, or use the IdentityMap).

    Low priority for me personally, but if you'd like to spec and provide a patch I'd be happy to apply it.

    Maybe someone else will take it on in the mean-time. Or we might be able to squeeze it in next week.

  • Sam Smoot

    Sam Smoot May 8th, 2008 @ 11:22 PM

    FYI, DM3 didn't have the option of skipping a key. It added an :id if you didn't define your own. So the eventual support of this would be an 0.9.0 exclusive feature.

    It will need good specs though since there's lots of introspection (like for associations, lazy-loading, reloading) that just won't work by defaults without defining a key. Or in the associations, passing the association key at least.

  • Sam Smoot

    Sam Smoot May 8th, 2008 @ 11:27 PM

    • Milestone cleared.
  • Dan Kubb (dkubb)

    Dan Kubb (dkubb) November 28th, 2008 @ 02:20 AM

    • State changed from “new” to “invalid”

    Like Sam said, keys are a requirement at this time. There's too many things that depend on keys being present in a Resource. Perhaps we can reopen this at some point, but for now and the foreseeable future this will be the case.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

People watching this ticket