Datamapper DataMapper

Comments and changes to this ticket

• You flagged this item as spam.
  

  Sam Smoot March 15th, 2008 @ 06:42 PM

  • State changed from “new” to “open”

  I think a better solution to this issue might involve introducing the concept of validator precedence. Just like + takes higher precedence than /, we can make some assumptions about validations such as a validates_presence_of takes precedence over anything else.

  Poke holes please. ;-)

  I do think the internal mechanisms should account for declared order, it's the inlines I'm not so sure about since they're more than just validators. They can also be field definitions/constraints.

• 

  Dan Kubb (dkubb) April 15th, 2008 @ 03:34 AM

  • Milestone cleared.

• You flagged this item as spam.
  

  Sam Smoot May 21st, 2008 @ 01:26 AM

  • Assigned user set to “Adam French”

  Adam,

  A feature for you to implement! :-)

  Validation precedence as auto-validations are concerned.

  Just to clarify: Standard validations should preserve the order in which they are defined. Auto-validations should provide a precedence to give the Hash options some more meaning.

  So the change here is that we need to map/select something like:

  [:nullable, :length, :format].each do |type|
    if options.has_key?(type)
      case type
      when :nullable then validates_is_present(name)
      when :length then validates_length(name, option[:length])
      else raise 'CAN BE AWESOMES!'
      end
    end
  end
  

  You get the point. Precedence for auto-validations only.

• You flagged this item as spam.
  

  Sam Smoot June 2nd, 2008 @ 04:56 PM

  • Milestone cleared.

• You flagged this item as spam.
  

  Adam French July 20th, 2008 @ 05:46 PM

  • Assigned user cleared.
  • Tag set to “dm-more, patch, property”
• 

  Dan Kubb (dkubb) December 12th, 2008 @ 03:25 PM

  • Tag changed from “dm-more, patch, property” to “dm-more, property”
  • State changed from “open” to “resolved”

  This patch does not cleanly apply to dm-core.

  It looks like dm-validations has been updated so that auto-validation proceeds in a predefined manner, and validations are executed in the order they are defined in.