Gemfiles use ADAPTER and ADAPTERS, dm-core/spec/setup only uses ADAPTER
Reported by Postmodern | November 19th, 2010 @ 08:30 PM | in 1.1
I noticed that most all DM Gemfiles use both the ADAPTER and ADAPTERS env variables, while dm-core/spec/setup only uses the ADAPTER env variable. This can be very confusing at times.
https://github.com/datamapper/dm-core/blob/master/Gemfile#L41
https://github.com/datamapper/dm-core/blob/master/lib/dm-core/spec/...
Comments and changes to this ticket
-
Martin Gamsjaeger (snusnu) November 21st, 2010 @ 03:57 PM
- State changed from “new” to “confirmed”
I see how that can be confusing. The original intent though, is that regular
rake specfor dm-core only runs on one adapter, whereas the Gemfile supports bundling more than one adapter. That was the reason for why it is the way it is, iirc. -
Martin Gamsjaeger (snusnu) January 14th, 2011 @ 07:37 PM
- State changed from “confirmed” to “not-applicable”
- Assigned user set to “Martin Gamsjaeger (snusnu)”
- Milestone set to “1.1”
- Milestone order changed from “196309” to “0”
Somehow I think it would even be more confusing if dm-core would accept an ADAPTERS env variable, but then only accept a single adapter as value for that. Marking it not applicable for now, if you really feel strongly about it, feel free to reopen :)
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Martin Gamsjaeger (snusnu)
Piotr Solnica (solnic)