#1439 ✓resolved
Luke Pearce

rails_datamapper Fix read from string error

Reported by Luke Pearce | October 28th, 2010 @ 06:31 AM | in 1.1

Hiya,

Sent a pull request - wasn't sure if I needed to put a message here too?

http://github.com/datamapper/rails_datamapper/pull/1

When running the latest version (1.0.2) I get:

/Library/Ruby/Gems/1.8/gems/rails_datamapper-1.0.2/lib/rails_datamapper.rb:25:in _unmemoized_full_config':NoMethodError: undefined methodread' for /Users/luke/rails/event-logger/trunk/config/database.yml

I just changed the full_config method to do a File.read instead of trying to do a .read on a config_file string.

Hope this is ok

Cheers
Luke

Comments and changes to this ticket

  • Martin Gamsjaeger (snusnu)

    Martin Gamsjaeger (snusnu) October 29th, 2010 @ 02:21 PM

    • State changed from “new” to “resolved”
    • Milestone set to 1.1
    • Assigned user set to “Martin Gamsjaeger (snusnu)”
    • Milestone order changed from “196302” to “0”

    Thx! I just merged the pull request.

  • Martin Gamsjaeger (snusnu)

    Martin Gamsjaeger (snusnu) October 29th, 2010 @ 02:46 PM

    Luke,

    Coming to think about it, I think it's good to have a LH ticket related to a pull request on github. While it may seem duplicated effort at first, it allows us to track changes (resolved tickets) between releases in a single place (Lighthouse). I think that for bugs at least, it's good to have tickets on LH too. We can then see how many of them we resolved between releases.

    Additionally, if you happen to have a pull request / patch that fixes a ticket already filed in LH, you can add [#1439 state:resolved] to your commit message (after a blank line, 1439 being the ticket id). This will make sure that when merging the pull request, the related LH tickets gets marked as resolved too.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Referenced by

Pages