Datamapper DataMapper

Comments and changes to this ticket

• You flagged this item as spam.
  

  Adam French January 26th, 2008 @ 01:31 PM

  • State changed from “new” to “open”

  you can do:

     property :pk_user_id, :integer, :key => true
  

  and that should emulate set_primary_key. If it doesn't, hit me back.

• You flagged this item as spam.
  

  Adam French February 1st, 2008 @ 09:38 PM

  @alan => that work?

• You flagged this item as spam.
  

  Sam Smoot February 8th, 2008 @ 01:38 PM

  • State changed from “open” to “invalid”

  Closing this out...

• You flagged this item as spam.
  

  Michael Boutros February 8th, 2008 @ 10:24 PM

  Do you guys think that there should be a 'set_primary_key' method, since: a) there is a 'set_table_name' method to do the same thing for tables, and more compellingly, b) it'll be easier to document. Where in the docs could it be mentioned that this is how to change the primary key? It'd be thrown somewhere randomly, and for people just searching the docs they wouldn't find it. I'm sure it wouldn't be too hard to implement, I'll whip up a patch tomorrow.

• You flagged this item as spam.
  

  asceth February 9th, 2008 @ 01:11 AM

  Unless the patch works directly with the property method I don't see how this would be beneficial and even then it sounds like it would be a bit of cleverness over what should be simple. #set_table_name only exists because there is no other way to define the table name.

  #property is meant to define columns and has the ability to define the primary keys. Adding #set_primary_key would be duplication of functionality and would need to go through the properties defined and update that one.

  In documentation you can update it under DataMapper::Persistence to point to where it should be defined. This could also open up a intro/tutorial on how to support legacy databases on the website.

  These are just my views so don't let me turn you off on creating the patch.

• You flagged this item as spam.
  

  Adam French February 11th, 2008 @ 10:22 AM

  I've added a section in the new FAQ to cover this. I want to say there's even a section on the Property documentation which covers Keys as well.

• You flagged this item as spam.
  

  Michael Boutros February 11th, 2008 @ 02:59 PM

  Yep, there is a paragraph in Property's documentation about adding keys, and primary keys in legacy databases is covered.

• You flagged this item as spam.
  

  Sam Smoot February 11th, 2008 @ 08:41 PM

  Alan:

  A patch would be great, but I think we want to add that specifically to a ActiveRecordCompatibility module that can be optionally included.

  Don't want to litter the core namespace with compatibility methods regular users aren't likely to use anyways right?

  I don't think it's terribly important where this file goes... AR users who want it can just require & include it to decorate the DM namespace.

• You flagged this item as spam.
  

  Michael Boutros February 11th, 2008 @ 09:57 PM

  Alan, feel free to create a new ticket for your problem. No one will get mad at you for trying to help out :) If you want to really one-on-one with Sam and the other big-timers, you can usually find them in the IRC channel: #datamapper on irc.freenode.net. If for some reason you can never catch them online, creating a ticket will definitely get their attention.

• You flagged this item as spam.
  

  Sam Smoot February 12th, 2008 @ 07:27 PM

  Alan, you can find my email addy through the mailing-list. I'd paste it here, but you know... :-)

  http://groups.google.com/group/d...

  We've been over RETURNING before, but I forget why we rejected it... I think maybe it was just because we would need to inspect the query if we did it at the driver level? Not sure. Be happy to chat about it sometime.

  Hate doing too much on email/IRC tho'. I'm just lazy like that. ;-) So if you've got time for an ichat sometime...

  Of course, as Michael suggested, I'm on IRC pretty frequently, so feel free to drop in and ping me.

• You flagged this item as spam.
  

  Michael Boutros February 12th, 2008 @ 09:24 PM

  Sam, I've been working on adding this and I've got it working:

  class Article < DataMapper::Base
    include_compatibility_methods
    set_primary_key 'title', :string
    
    property :description, :string
  end
  

  Is that good for everyone? We could also add more methods to the Compatibility module at a later date.

• You flagged this item as spam.
  

  Michael Boutros February 12th, 2008 @ 11:00 PM

  I want to add a patch, but I'm having some trouble - how can I get git to add to the diff file the new file (compatibility.rb) that I created?