Gemfiles are too aggressive with their adapter dependencies.
Reported by Postmodern | April 21st, 2010 @ 02:43 AM | in 1.0.0
The standard DataMapper Gemfile lists all of the adapters as dependencies. This is problematic, as most of these adapters require header files and libraries to be installed in order to compile various C extensions. If the extensions cannot be compiled it will likely prevent bundler from completing successfully, or will prevent the libraries from being loaded.
Perhaps we could take the same approach as with the default spec/spec_helper.rb, and pass an ADAPTERS environment variable into the Gemfile:
group :test_adapters do
if ENV['ADAPTERS']
adapters = ENV['ADAPTERS'].split(/\s+/).map { |name|
name.downcase
}.uniq
adapters.each do |name|
gem "dm-adapter-#{name}", '~> 0.10.3', :git => "#{datamapper}/dm-adapter-#{name}.git"
end
end
end
Comments and changes to this ticket
-
Piotr Solnica (solnic) April 21st, 2010 @ 03:06 AM
- State changed from “new” to “not-applicable”
This is exactly what has been done recently: http://github.com/datamapper/dm-core/blob/master/Gemfile
-
Martin Gamsjaeger (snusnu) April 21st, 2010 @ 08:18 AM
- Milestone set to “1.0.0”
- State changed from “not-applicable” to “resolved”
Yeah, like Piotr said, have a look at the latest commit to the Gemfile. We now manage ADAPTERS and PLUGINS and allow creating a Gemfile.local.
-
Postmodern April 21st, 2010 @ 08:22 AM
Nice. I only was looking at dm-migrations. I suppose it will take some time to propagate the Gemfile across all DM libraries.
-
Martin Gamsjaeger (snusnu) April 21st, 2010 @ 08:41 AM
Yeah, it will take some time until all the gems have the "new Gemfile format". I wanted to get it right before starting to copy the structure to the ~40 gems :P That said, anything missing, or not the way you'd expect it to be?
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Martin Gamsjaeger (snusnu)
Piotr Solnica (solnic)