Datamapper DataMapper → 1.0.0

Comments and changes to this ticket

• 

  Alex Coles November 13th, 2009 @ 06:01 AM

  • State changed from “unconfirmed” to “accepted”
• 

  Alex Coles November 16th, 2009 @ 09:10 AM

  • State changed from “accepted” to “not-applicable”

  others couldn't confirm this one and after reinstalling dependencies, I'm no longer able to reproduce this issue.

• 

  Alex Coles November 16th, 2009 @ 01:32 PM

  • State changed from “not-applicable” to “accepted”

  Re-opened. Report of this occurring in #datamapper channel.

• You flagged this item as spam.
  

  Peter Brant November 17th, 2009 @ 06:35 PM

  It might have a different root cause, but the explanation for this behavior is likely the same as I was seeing with the PG adapter. If there is a problem loading DoSqlite3ExtService, JRuby silently eats the exception. The result is that the entire Connection class consists of

    module DataObjects
      module Sqlite3
        class Connection
          def self.pool_size
            # sqlite3 can have only one write access at a time, with this
            # concurrent write access will result in "Database locked" errors
            1
          end
        end
      end
  

  which, of course, doesn't have an initialize method that takes the URL to connect to.

  JRuby's handling of this is pretty atrocious, IMO. The only way I could figure out what was going on was running JRuby (and Tomcat in my case) under the debugger.

• 

  Dan Kubb (dkubb) November 18th, 2009 @ 04:38 AM

  (from [da1b14f6c2c98289824bcd9fc18feddb02de1742]) Prefer class_eval to reopening Connection class

  • Should aid situation where JRuby extension (do_DRIVER_ext.jar) does not load and no Error is raised. (Re-)opening the class in these situations was causing an ArgumentError to be raised (because the correct #initialize method is not defined) rather than a constant missing error.
  • Thanks to Peter Brant for helping diagnosis this behaviour.
  • Remove overriden pool_size: this is now defined for JRuby in DataObjects::Pooling.

  [#1122]

  Signed-off-by: Alex Coles alex@alexcolesportfolio.com
  http://github.com/datamapper/do/commit/da1b14f6c2c98289824bcd9fc18f...

• 

  Dan Kubb (dkubb) February 1st, 2010 @ 04:33 PM

  • Milestone changed from “0.10.2” to “1.0.0”

  [bulk edit]

• 

  Dan Kubb (dkubb) May 26th, 2010 @ 01:25 AM

  • State changed from “accepted” to “resolved”

  I just ran the dm-core specs with dm-sqlite3-adapter on JRuby and all specs pass. Marking this as resolved for now. If it is not, please create a new ticket or reopen this with a test case or instructions to reproduce the problem.