
dm-tags blank input doesn't delete tags
Reported by Max Hawkins | August 13th, 2009 @ 12:44 AM | in 0.10.0
Updating a model with existing tags after setting the #{singular}list attribute to an empty string has no effect on the existing tags. The attached patch deletes the line that rejects changes with an empty #{singular}list and adds a spec to verify the behavior.
This allows tags to be deleted directly through a model's edit form by setting the tags string to "".
Comments and changes to this ticket
-
Martin Gamsjaeger (snusnu) August 18th, 2009 @ 09:01 AM
- State changed from new to accepted
- Assigned user set to Martin Gamsjaeger (snusnu)
- Milestone set to 0.10.0
-
Dan Kubb (dkubb) August 18th, 2009 @ 06:24 PM
- State changed from accepted to resolved
(from [f2740fb38505786e9471ef1305fc1311873c49aa]) [dm-tags] Support deleting tags using the tag list writer methods
-
Calling the generated tag_list writer methods with a blank String will delete all the receiver's tags.
-
Thx to Max Hawkins for the meat of this patch.
[#1006 state:resolved] http://github.com/datamapper/dm-more/commit/f2740fb38505786e9471ef1...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
People watching this ticket
Attachments
Tags
Referenced by
-
1006 dm-tags blank input doesn't delete tags [#1006 state:resolved] http://github.com/datamapper/dm-m...