Changeset [da1b14f6c2c98289824bcd9fc18feddb02de1742] by Alex Coles

November 18th, 2009 @ 04:36 AM

Prefer class_eval to reopening Connection class

  • Should aid situation where JRuby extension (do_DRIVER_ext.jar) does not load and no Error is raised. (Re-)opening the class in these situations was causing an ArgumentError to be raised (because the correct #initialize method is not defined) rather than a constant missing error.
  • Thanks to Peter Brant for helping diagnosis this behaviour.
  • Remove overriden pool_size: this is now defined for JRuby in DataObjects::Pooling.

[#1122]

Signed-off-by: Alex Coles alex@alexcolesportfolio.com
http://github.com/datamapper/do/commit/da1b14f6c2c98289824bcd9fc18f...

Committed by Alex Coles

  • M do_derby/lib/do_derby.rb
  • M do_h2/lib/do_h2.rb
  • M do_hsqldb/lib/do_hsqldb.rb
  • M do_mysql/lib/do_mysql.rb
  • M do_oracle/lib/do_oracle.rb
  • M do_postgres/lib/do_postgres.rb
  • M do_sqlite3/lib/do_sqlite3.rb
  • M do_sqlserver/lib/do_sqlserver.rb
New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »