[PATCH] aggregates for in_memory_adapter (1/2)
Reported by Gary Yngve | December 9th, 2008 @ 02:33 AM
with dm-aggregates, size() now defaults to count() if not loaded, which breaks in_memory_adapter.
this is an aggregates implementation for in_memory_adapter that passes all but a few (made pending) specs involving grouping, assocations, etc., that in_mem doesn't support at all.
patch 1/2 (i'm a git newb)
Comments and changes to this ticket
-
-
Dan Kubb (dkubb) December 12th, 2008 @ 02:52 PM
- State changed from “unconfirmed” to “confirmed”
It appears as if this patch includes code that was cut and pasted from other specs. Would you mind refactoring some of the common code into shared libs? See dkubb/dm-core on github for an example of how to nicely organize the shared specs.
I don't want to run into a situation where we have nearly identical specs in two places, and we modify one and not the other. This is one of the things that happened in sam/dm-core and it's take a huge effort to clean it up in dkubb/dm-core, which we are still working on.
-
Dan Kubb (dkubb) December 13th, 2008 @ 12:01 PM
- Assigned user cleared.
- Tag set to “patch”
- State changed from “confirmed” to “hold”
-
Dan Kubb (dkubb) January 8th, 2009 @ 04:57 AM
- State changed from “hold” to “not-applicable”
dm-aggregates was rolled back to not use count, so I am going to close this ticket.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Dan Kubb (dkubb)
Gary Yngve
Lin Jen-Shin