#187 invalid
James Herdman

Improve README Quality

Reported by James Herdman | March 22nd, 2008 @ 08:56 PM

I cleaned up the English and made it generally more readable.

Comments and changes to this ticket

  • James Herdman
  • Dan Kubb (dkubb)

    Dan Kubb (dkubb) April 14th, 2008 @ 05:52 PM

    • Milestone cleared.
    • State changed from “new” to “open”
  • Sam Smoot

    Sam Smoot April 27th, 2008 @ 10:46 PM

    • Assigned user set to “Adam French”

    Adam, please review and apply this patch, then close this ticket.

  • Adam French

    Adam French April 28th, 2008 @ 12:58 AM

    • Milestone cleared.

    the patch is for 0.3.0's README file. I'll scan through it and adapt what I can for 0.9.0, though.

    When attempting to apply it with

    git apply --verbose 0001-Improve-README.patch

    I keep getting:

    Checking patch README...
    error: while searching for:
    see all <tt>false</tt> results. Do the same in DataMapper and it's
    <tt>true</tt> all the way down.
      @parent = Tree.find(:first, :conditions => ['name = ?', 'bob'])
      @parent.children.each do |child|
        puts @parent.object_id == ch
    error: patch failed: README:21
    error: README: patch does not apply
  • Adam French

    Adam French April 28th, 2008 @ 12:35 PM

    • State changed from “open” to “invalid”

    @james_herdman : If you'd like, I can set you up with commit bits on the rubyforge 0.3.0 branch so we can get this patch applied. Ping me or Sam if you're up for it.

    Otherwise I'm feeling pressure to close this out un-applied.

    Thanks for your contribution, though. Always appreciated, even if they don't get applied or confuse the applyer.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

People watching this ticket