"has n, :through..." does not allow saving of model

5609

true

2008-07-26T18:56:51-05:00

26603

485 has-n-through-does-not-allow-saving-of-model 15665

20609

resolved associations dm-core has_and_belongs_to_many "has n, :through..." does not allow saving of model

2009-05-28T03:27:19-05:00

5609

Dan Kubb (dkubb)

Bobby Calderwood

Dan Kubb (dkubb)

http://datamapper.lighthouseapp.com/projects/20609/tickets/485

<pre><code> class Taggable include DataMapper::Resource property :id, Integer, :serial => true has n, :taggings has n, :tags, :through => :taggings end class Tagging include DataMapper::Resource property :id, Integer, :serial => true belongs_to :taggable belongs_to :tag end class Tag include DataMapper::Resource property :id, Integer, :serial => true has n, :taggings has n, :taggables, :through => :taggings end taggable = Taggable.new taggable.tags taggable.save </code></pre> Trying to access the remote association and then saving raises this strange error: <pre> DataMapper::Associations::ImmutableAssociationError: You can not modify this assocation from /Library/Ruby/Gems/1.8/gems/dm-core-0.9.3/lib/dm-core/associations/one_to_many.rb:247:in `assert_mutable' from /Library/Ruby/Gems/1.8/gems/dm-core-0.9.3/lib/dm-core/associations/one_to_many.rb:199:in `save' from /Library/Ruby/Gems/1.8/gems/dm-core-0.9.3/lib/dm-core/resource.rb:272:in `hookable__save_nan_before_advised' from /Library/Ruby/Gems/1.8/gems/dm-core-0.9.3/lib/dm-core/resource.rb:272:in `each' from /Library/Ruby/Gems/1.8/gems/dm-core-0.9.3/lib/dm-core/resource.rb:272:in `hookable__save_nan_before_advised' from /Library/Ruby/Gems/1.8/gems/extlib-0.9.3/lib/extlib/hook.rb:294:in `save!' from /Library/Ruby/Gems/1.8/gems/extlib-0.9.3/lib/extlib/hook.rb:292:in `catch' from /Library/Ruby/Gems/1.8/gems/extlib-0.9.3/lib/extlib/hook.rb:292:in `save!' from /Library/Ruby/Gems/1.8/gems/dm-validations-0.9.3/lib/dm-validations.rb:44:in `save' from (irb):39 </pre>

<div> class Taggable include DataMapper::Resource property :id, Integer, :serial => true has n, :taggings has n, :tags, :through => :taggings end class Tagging include DataMapper::Resource property :id, Integer, :serial => true belongs_to :taggable belongs_to :tag end class Tag include DataMapper::Resource property :id, Integer, :serial => true has n, :taggings has n, :taggables, :through => :taggings end taggable = Taggable.new taggable.tags taggable.save Trying to access the remote association and then saving raises this strange error: DataMapper::Associations::ImmutableAssociationError: You can not modify this assocation from /Library/Ruby/Gems/1.8/gems/dm-core-0.9.3/lib/dm-core/associations/one_to_many.rb:247:in `assert_mutable' from /Library/Ruby/Gems/1.8/gems/dm-core-0.9.3/lib/dm-core/associations/one_to_many.rb:199:in `save' from /Library/Ruby/Gems/1.8/gems/dm-core-0.9.3/lib/dm-core/resource.rb:272:in `hookable__save_nan_before_advised' from /Library/Ruby/Gems/1.8/gems/dm-core-0.9.3/lib/dm-core/resource.rb:272:in `each' from /Library/Ruby/Gems/1.8/gems/dm-core-0.9.3/lib/dm-core/resource.rb:272:in `hookable__save_nan_before_advised' from /Library/Ruby/Gems/1.8/gems/extlib-0.9.3/lib/extlib/hook.rb:294:in `save!' from /Library/Ruby/Gems/1.8/gems/extlib-0.9.3/lib/extlib/hook.rb:292:in `catch' from /Library/Ruby/Gems/1.8/gems/extlib-0.9.3/lib/extlib/hook.rb:292:in `save!' from /Library/Ruby/Gems/1.8/gems/dm-validations-0.9.3/lib/dm-validations.rb:44:in `save' from (irb):39 </div>

3477

0 <pre><code> class Taggable include DataMapper::Resource property :id, Integer, :serial => true has n, :taggings has n, :tags, :through => :taggings end class Tagging include DataMapper::Resource property :id, Integer, :serial => true belongs_to :taggable belongs_to :tag end class Tag include DataMapper::Resource property :id, Integer, :serial => true has n, :taggings has n, :taggables, :through => :taggings end taggable = Taggable.new taggable.tags taggable.save </code></pre> Trying to access the remote association and then saving raises this strange error: <pre> DataMapper::Associations::ImmutableAssociationError: You can not modify this assocation from /Library/Ruby/Gems/1.8/gems/dm-core-0.9.3/lib/dm-core/associations/one_to_many.rb:247:in `assert_mutable' from /Library/Ruby/Gems/1.8/gems/dm-core-0.9.3/lib/dm-core/associations/one_to_many.rb:199:in `save' from /Library/Ruby/Gems/1.8/gems/dm-core-0.9.3/lib/dm-core/resource.rb:272:in `hookable__save_nan_before_advised' from /Library/Ruby/Gems/1.8/gems/dm-core-0.9.3/lib/dm-core/resource.rb:272:in `each' from /Library/Ruby/Gems/1.8/gems/dm-core-0.9.3/lib/dm-core/resource.rb:272:in `hookable__save_nan_before_advised' from /Library/Ruby/Gems/1.8/gems/extlib-0.9.3/lib/extlib/hook.rb:294:in `save!' from /Library/Ruby/Gems/1.8/gems/extlib-0.9.3/lib/extlib/hook.rb:292:in `catch' from /Library/Ruby/Gems/1.8/gems/extlib-0.9.3/lib/extlib/hook.rb:292:in `save!' from /Library/Ruby/Gems/1.8/gems/dm-validations-0.9.3/lib/dm-validations.rb:44:in `save' from (irb):39 </pre> <div> <pre><code> class Taggable include DataMapper::Resource property :id, Integer, :serial => true has n, :taggings has n, :tags, :through => :taggings end class Tagging include DataMapper::Resource property :id, Integer, :serial => true belongs_to :taggable belongs_to :tag end class Tag include DataMapper::Resource property :id, Integer, :serial => true has n, :taggings has n, :taggables, :through => :taggings end taggable = Taggable.new taggable.tags taggable.save </code></pre> Trying to access the remote association and then saving raises this strange error: <pre> DataMapper::Associations::ImmutableAssociationError: You can not modify this assocation from /Library/Ruby/Gems/1.8/gems/dm-core-0.9.3/lib/dm-core/associations/one_to_many.rb:247:in `assert_mutable' from /Library/Ruby/Gems/1.8/gems/dm-core-0.9.3/lib/dm-core/associations/one_to_many.rb:199:in `save' from /Library/Ruby/Gems/1.8/gems/dm-core-0.9.3/lib/dm-core/resource.rb:272:in `hookable__save_nan_before_advised' from /Library/Ruby/Gems/1.8/gems/dm-core-0.9.3/lib/dm-core/resource.rb:272:in `each' from /Library/Ruby/Gems/1.8/gems/dm-core-0.9.3/lib/dm-core/resource.rb:272:in `hookable__save_nan_before_advised' from /Library/Ruby/Gems/1.8/gems/extlib-0.9.3/lib/extlib/hook.rb:294:in `save!' from /Library/Ruby/Gems/1.8/gems/extlib-0.9.3/lib/extlib/hook.rb:292:in `catch' from /Library/Ruby/Gems/1.8/gems/extlib-0.9.3/lib/extlib/hook.rb:292:in `save!' from /Library/Ruby/Gems/1.8/gems/dm-validations-0.9.3/lib/dm-validations.rb:44:in `save' from (irb):39 </pre> </div> false

2008-07-26T18:56:52-05:00

26603

--- {}

485 has-n-through-does-not-allow-saving-of-model 0

20609

new associations dm-core has_and_belongs_to_many "has n, :through..." does not allow saving of model

2008-07-26T18:56:52-05:00

26603

Bobby Calderwood

Sam Smoot

http://datamapper.lighthouseapp.com/projects/20609/tickets/485

3477

0 I just ran into this bug, too. Looks like the logic in OneToMany#assert_mutable (http://github.com/sam/dm-core/tree/master/lib/dm-core/associations/one_to_many.rb#L247) needs to account for :through associations. <div>I just ran into this bug, too. Looks like the logic in OneToMany#assert_mutable (<a href="http://github.com/sam/dm-core/tree/master/lib/dm-core/associations/one_to_many.rb#L247">http://github.com/sam/dm-core/tr...</a>) needs to account for :through associations.</div> false

2008-08-24T14:52:05-05:00

26603

--- {}

485 has-n-through-does-not-allow-saving-of-model 0

20609

new associations dm-core has_and_belongs_to_many "has n, :through..." does not allow saving of model

2008-08-24T14:52:05-05:00

29883

nicholaides

Bobby Calderwood

Sam Smoot

http://datamapper.lighthouseapp.com/projects/20609/tickets/485

3477

0 Is anybody looking into this? This is still a problem. The first error in this script highlights the problem as well: http://gist.github.com/raw/21256/fcc60e2e3dbff5ecc07f84c9394d1eeda960f464 <div>Is anybody looking into this? This is still a problem. The first error in this script highlights the problem as well: <a href="http://gist.github.com/raw/21256/fcc60e2e3dbff5ecc07f84c9394d1eeda960f464"> http://gist.github.com/raw/21256...</a></div> false

2008-11-10T18:38:30-06:00

26603

--- {}

485 has-n-through-does-not-allow-saving-of-model 0

20609

new associations dm-core has_and_belongs_to_many "has n, :through..." does not allow saving of model

2008-11-10T18:38:31-06:00

16843

Kyle Drake

Bobby Calderwood

Sam Smoot

http://datamapper.lighthouseapp.com/projects/20609/tickets/485

3477

0 I am curious - why is this not working? <div>I am curious - why is this not working?</div> false

2008-11-14T08:04:30-06:00

26603

--- {}

485 has-n-through-does-not-allow-saving-of-model 0

20609

new associations dm-core has_and_belongs_to_many "has n, :through..." does not allow saving of model

2008-11-14T08:04:33-06:00

14372

Vladimir Lushnikov

Bobby Calderwood

Sam Smoot

http://datamapper.lighthouseapp.com/projects/20609/tickets/485

3477

0 a workaround is @@@ class Tag include DataMapper::Resource property :id, Serial has n, :taggings has n, :tags, :through => :taggings, :mutable => true end @@@ adding this :mutable option. I think the opposite default for the mutable option would be a better choice. see the patch to see where to fix it (or apply the patch) <div>a workaround is <pre><code> class Tag include DataMapper::Resource property :id, Serial has n, :taggings has n, :tags, :through => :taggings, :mutable => true end </code></pre> adding this :mutable option. I think the opposite default for the mutable option would be a better choice. see the patch to see where to fix it (or apply the patch)</div> false

2008-11-17T13:41:50-06:00

26603

--- {}

485 has-n-through-does-not-allow-saving-of-model 0

20609

new associations dm-core has_and_belongs_to_many "has n, :through..." does not allow saving of model

2008-11-17T13:41:52-06:00

34710

kristian

Bobby Calderwood

Sam Smoot

http://datamapper.lighthouseapp.com/projects/20609/tickets/485

3477

1 The patch sent has the line: @mutable = options.delete(:mutable) || true That will always return true. You should something like: @mutable = options[:mutable] ? options.delete(:mutable) : true Regards, José Valim. <div>The patch sent has the line: @mutable = options.delete(:mutable) || true That will always return true. You should something like: @mutable = options[:mutable] ? options.delete(:mutable) : true Regards, José Valim.</div> false

2008-11-22T12:33:24-06:00

26603

--- {}

485 has-n-through-does-not-allow-saving-of-model 0

20609

new associations dm-core has_and_belongs_to_many "has n, :through..." does not allow saving of model

2008-11-22T12:33:27-06:00

19965

José Valim

Bobby Calderwood

Sam Smoot

http://datamapper.lighthouseapp.com/projects/20609/tickets/485

1 I'm not sure this is an issue. The through resource may well be some complex item which cannot be created from defaults. On the other hand, if it can, allowing that to happen is a good thing, <div>I'm not sure this is an issue. The through resource may well be some complex item which cannot be created from defaults. On the other hand, if it can, allowing that to happen is a good thing,</div> false

2008-11-30T09:22:12-06:00

26603

--- :state: new :assigned_user: 3477

485 has-n-through-does-not-allow-saving-of-model 0

20609

hold associations dm-core has_and_belongs_to_many "has n, :through..." does not allow saving of model

2008-11-30T09:22:13-06:00

21441

Jonathan Stott (namelessjon)

Bobby Calderwood

http://datamapper.lighthouseapp.com/projects/20609/tickets/485

1 I can confirm that has n, :through still exhibits this behavior. However, this is by design until we can work out the cases when the join record can be automatically created vs where it cannot. If the join record only contains references to both sides of the association, then no problem. If it contains reference AND properties with default values, also no problem. However, in the case where it references both sides AND has a property without a default, we'd still need to throw an exception because it will be impossible for DM to fill in the missing information when creating the join record. We just need to codify this so that :through associations can be modified in certain situations. This work will be ongoing in the dkubb/dm-core fork over the next couple of months. <div>I can confirm that has n, :through still exhibits this behavior. However, this is by design until we can work out the cases when the join record can be automatically created vs where it cannot. If the join record only contains references to both sides of the association, then no problem. If it contains reference AND properties with default values, also no problem. However, in the case where it references both sides AND has a property without a default, we'd still need to throw an exception because it will be impossible for DM to fill in the missing information when creating the join record. We just need to codify this so that :through associations can be modified in certain situations. This work will be ongoing in the dkubb/dm-core fork over the next couple of months.</div> false

2008-12-04T03:14:39-06:00

26603

--- :state: hold

485 has-n-through-does-not-allow-saving-of-model 0

20609

confirmed associations dm-core has_and_belongs_to_many "has n, :through..." does not allow saving of model

2008-12-04T03:14:42-06:00

5609

Dan Kubb (dkubb)

Bobby Calderwood

http://datamapper.lighthouseapp.com/projects/20609/tickets/485

5609

false

2009-01-07T16:26:06-06:00

26603

--- :assigned_user:

485 has-n-through-does-not-allow-saving-of-model 0

20609

confirmed associations dm-core has_and_belongs_to_many "has n, :through..." does not allow saving of model

2009-01-07T16:26:09-06:00

5609

Dan Kubb (dkubb)

Bobby Calderwood

Dan Kubb (dkubb)

http://datamapper.lighthouseapp.com/projects/20609/tickets/485

5609

false

2009-01-07T16:33:31-06:00

26603

--- :state: confirmed

485 has-n-through-does-not-allow-saving-of-model 0

20609

accepted associations dm-core has_and_belongs_to_many "has n, :through..." does not allow saving of model

2009-01-07T16:33:32-06:00

5609

Dan Kubb (dkubb)

Bobby Calderwood

Dan Kubb (dkubb)

http://datamapper.lighthouseapp.com/projects/20609/tickets/485

5609

1 @José Valim This: @@@ruby @mutable = options[:mutable] ? options.delete(:mutable) : true @@@ will also return true ALWAYS. options[:mutable] can return "nil" or "false", if it will return false condition will not be met and will choose "true". Better would be: @@@ruby @mutable = options.key?(:mutable) ? options.delete(:mutable) : true @@@ <div>@José Valim This: @@@ruby @mutable = options[:mutable] ? options.delete(:mutable) : true <pre><code> will also return true ALWAYS. options[:mutable] can return "nil" or "false", if it will return false condition will not be met and will choose "true". Better would be: @@@ruby @mutable = options.key?(:mutable) ? options.delete(:mutable) : true </code></pre></div> false

2009-01-08T05:22:14-06:00

26603

--- {}

485 has-n-through-does-not-allow-saving-of-model 0

20609

accepted associations dm-core has_and_belongs_to_many "has n, :through..." does not allow saving of model

2009-01-08T05:22:15-06:00

34912

Marcin Kulik

Bobby Calderwood

Dan Kubb (dkubb)

http://datamapper.lighthouseapp.com/projects/20609/tickets/485

5609

1 I can confirm this issue is resolved in dm-core/next. Attached is a script to demonstrate the fix. <div>I can confirm this issue is resolved in dm-core/next. Attached is a script to demonstrate the fix.</div> true

2009-05-28T03:27:16-05:00

26603

--- :state: accepted

485 has-n-through-does-not-allow-saving-of-model 0

20609

resolved associations dm-core has_and_belongs_to_many "has n, :through..." does not allow saving of model

2009-05-28T03:27:19-05:00

5609

Dan Kubb (dkubb)

Bobby Calderwood

Dan Kubb (dkubb)

http://datamapper.lighthouseapp.com/projects/20609/tickets/485 c9623af7e071818474b045a3eaae8e904d830f02

application/octet-stream

2008-11-17T13:41:50-06:00

patch 62878 575

34710

http://datamapper.lighthouseapp.com/attachments/62878/patch f5a727f7bf32d64f1acf65dcaa6098e27acb8144

application/octet-stream

2009-05-28T03:27:16-05:00

ticket-485.rb 127051 613

5609

http://datamapper.lighthouseapp.com/attachments/127051/ticket-485.rb